fix: clean up properly shared modal page router outlets #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
manoldonev
requested review from
MartoYankov,
vakrilov,
sis0k0,
ADjenkov and
vchimev
vakrilov
previously approved these changes
Jun 5, 2018
| this.currentUrlTree.root.children[this.currentOutlet] = state.segmentGroup; | ||
| if (state) { | ||
| this.currentUrlTree.root.children[this.currentOutlet] = state.segmentGroup; | ||
| } else { |
There was a problem hiding this comment.
Suggestion: add a comment on when state comes in as undefined and why the cleanup logic is needed.
manoldonev
force-pushed
the
mdonev/outlet-cleanup-fix
branch
3 times, most recently
from
3b3cd3d to
6e7c051
Compare
manoldonev
force-pushed
the
mdonev/outlet-cleanup-fix
branch
from
6e7c051 to
8345daa
Compare
|
Hi guys, |
|
@jolafrite as soon as the tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix named page router outlets cleanup to enable scenarios where modal dialog is "shared" i.e. it is attached to the root viewContainerRef and can be opened from different host components without the need to define specific child route for each host component.
Fixes #340